Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve WalletConnect checks #3899

Merged
merged 4 commits into from
Mar 16, 2022
Merged

Improve WalletConnect checks #3899

merged 4 commits into from
Mar 16, 2022

Conversation

andrepimenta
Copy link
Member

@andrepimenta andrepimenta commented Mar 16, 2022 •
edited

Description

How to QA: reach out to @andrepimenta

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #???

@andrepimenta andrepimenta requested a review from a team as a code owner March 16, 2022 11:41
@andrepimenta andrepimenta added needs-qa Any New Features that needs a full manual QA prior to being added to a release. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Priority - High Task with high priority labels Mar 16, 2022
gantunesr
gantunesr approved these changes Mar 16, 2022
View reviewed changes
Copy link
Member

@gantunesr gantunesr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gantunesr gantunesr removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Mar 16, 2022
@cortisiko cortisiko added QA in Progress QA has started on the feature. and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Mar 16, 2022
Gustavo Antunes and others added 2 commits March 16, 2022 12:34
Merge branch 'main' into fix/fix-wc-checks
58a6f70
@andrepimenta
Fix gas price being zero (#3903)
0d80e75 
* Fix gas price being zero

* Remove unused variable conversionRate
cortisiko
cortisiko approved these changes Mar 16, 2022
View reviewed changes
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮 🌮 🌮 🌮

@cortisiko cortisiko added QA Passed A successful QA run through has been done and removed QA in Progress QA has started on the feature. labels Mar 16, 2022
@andrepimenta andrepimenta merged commit 7b4d9ec into main Mar 16, 2022
@andrepimenta andrepimenta deleted the fix/fix-wc-checks branch March 16, 2022 22:45
@github-actions github-actions bot locked and limited conversation to collaborators Mar 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cortisiko cortisiko cortisiko approved these changes

@gantunesr gantunesr gantunesr approved these changes

Assignees
No one assigned
Labels
Priority - High Task with high priority QA Passed A successful QA run through has been done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andrepimenta @cortisiko @gantunesr