Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash on sign message popup #3900

Merged
merged 1 commit into from
Mar 16, 2022
Merged

Fix crash on sign message popup #3900

merged 1 commit into from
Mar 16, 2022

Conversation

Fatxx
Copy link
Contributor

@Fatxx Fatxx commented Mar 16, 2022

Description

Safely delete property on a new object instead of deleting the original one which further causes the object to be undefined and resulting in a crash.

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #???

@Fatxx Fatxx requested a review from a team as a code owner March 16, 2022 11:50
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

jpcloureiro
jpcloureiro approved these changes Mar 16, 2022
View reviewed changes
Copy link
Contributor

@jpcloureiro jpcloureiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Fatxx Fatxx added the Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking label Mar 16, 2022
@Fatxx Fatxx merged commit 63c49ae into main Mar 16, 2022
@Fatxx Fatxx deleted the bugfix/sign-eth-modal-crash branch March 16, 2022 12:01
@github-actions github-actions bot locked and limited conversation to collaborators Mar 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jpcloureiro jpcloureiro jpcloureiro approved these changes

@andrepimenta andrepimenta andrepimenta approved these changes

Assignees
No one assigned
Labels
Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Fatxx @jpcloureiro @andrepimenta