-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix add custom token #3942
Fix add custom token #3942
Conversation
cf5dae2
to
57a8724
Compare
57a8724
to
21fa61d
Compare
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
I have read the CLA Document and I hereby sign the CLA |
use TokenImage component when rendering token logo
21fa61d
to
2605227
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work @jpcloureiro! Left some comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Getting the following error when running
|
@chrisleewilcox this was fixed here b9d3f4b, updating this branch with main will fix it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is a recording of the test. Data is shown as expected and token icon is shown.
https://recordit.co/pjMnCIaTr4
LGTM
Description
Fix payload when adding a custom token (wallet_watchAsset rpc call). Also use the token logo if provided.
wallet_watchAsset rpc method spec
Checklist
Issue
Resolves #3722