Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Update button on WebviewError #3948

Merged
merged 11 commits into from
Mar 30, 2022
Merged

[FIX] Update button on WebviewError #3948

merged 11 commits into from
Mar 30, 2022

Conversation

gantunesr
Copy link
Member

@gantunesr gantunesr commented Mar 24, 2022 •
edited

Description

Change reload button to "Return Home" on WebviewError component

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #???

@gantunesr gantunesr added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking labels Mar 24, 2022
@gantunesr gantunesr requested a review from a team as a code owner March 24, 2022 00:03
@gantunesr gantunesr changed the title Fix/remove button [FIX] Remove button on WebviewError Mar 24, 2022
Fatxx
Fatxx approved these changes Mar 28, 2022
View reviewed changes
Copy link
Contributor

@Fatxx Fatxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gantunesr gantunesr changed the title [FIX] Remove button on WebviewError [FIX] Update button on WebviewError Mar 30, 2022
@gantunesr gantunesr requested a review from Fatxx March 30, 2022 02:19
@gantunesr gantunesr removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Mar 30, 2022
@gantunesr gantunesr merged commit db467d0 into main Mar 30, 2022
@gantunesr gantunesr deleted the fix/remove-button branch March 30, 2022 19:22
@github-actions github-actions bot locked and limited conversation to collaborators Mar 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Fatxx Fatxx Fatxx approved these changes

Assignees
No one assigned
Labels
Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gantunesr @Fatxx @cortisiko