Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Issue #207 #4035

Merged
merged 24 commits into from
Apr 27, 2022
Merged

[FIX] Issue #207 #4035

merged 24 commits into from
Apr 27, 2022
+176 −47

Conversation

gantunesr
Copy link
Member

Description

Issue #207

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@gantunesr gantunesr added needs-qa Any New Features that needs a full manual QA prior to being added to a release. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Apr 5, 2022
@gantunesr gantunesr requested a review from a team as a code owner April 5, 2022 03:38
@chrisleewilcox chrisleewilcox added QA in Progress QA has started on the feature. and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Apr 8, 2022
@chrisleewilcox chrisleewilcox self-assigned this Apr 8, 2022
@chrisleewilcox chrisleewilcox added the QA'd but questions A QA run through has been done but you need clarification on minor issues you found label Apr 8, 2022
@chrisleewilcox chrisleewilcox added QA in Progress QA has started on the feature. and removed QA in Progress QA has started on the feature. labels Apr 12, 2022
@chrisleewilcox
Copy link
Contributor

chrisleewilcox commented Apr 13, 2022 •
edited

Browser: Uniswap: After setting custom spend limit and approving USDT ==> UNI swap, I am not able to approve swapping back the uni for usdt now. Always getting the JSON-RPC error...
https://recordit.co/nOhFzutlbh

@chrisleewilcox chrisleewilcox removed the QA in Progress QA has started on the feature. label Apr 13, 2022
@chrisleewilcox
Copy link
Contributor

Getting way too many JSON-RPC errors during approval and swaps that I don't feel confident the testing will be effective for swaping on dapps. Please address JSON-RPC errors.

@chrisleewilcox chrisleewilcox added the QA in Progress QA has started on the feature. label Apr 14, 2022
@gantunesr gantunesr added QA'd but questions A QA run through has been done but you need clarification on minor issues you found QA in Progress QA has started on the feature. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Mobile QA board and removed QA'd but questions A QA run through has been done but you need clarification on minor issues you found QA in Progress QA has started on the feature. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Mobile QA board labels Apr 19, 2022
@cortisiko cortisiko removed the QA'd but questions A QA run through has been done but you need clarification on minor issues you found label Apr 25, 2022
@plasmacorral plasmacorral added QA Passed A successful QA run through has been done and removed QA in Progress QA has started on the feature. labels Apr 27, 2022
sethkfman
sethkfman approved these changes Apr 27, 2022
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gantunesr gantunesr removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Apr 27, 2022
@gantunesr gantunesr merged commit b11b9df into main Apr 27, 2022
@gantunesr gantunesr deleted the fix/allowance-crash branch April 27, 2022 22:27
@github-actions github-actions bot locked and limited conversation to collaborators Apr 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sethkfman sethkfman sethkfman approved these changes

Assignees

@plasmacorral plasmacorral

Labels
QA Passed A successful QA run through has been done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@gantunesr @chrisleewilcox @sethkfman @cortisiko @plasmacorral