Metrics only enabled when confirm button is pressed #4099
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
gantunesr
added
needs-qa
chrisleewilcox
added
QA in Progress
chrisleewilcox
approved these changes
Apr 15, 2022
There was a problem hiding this comment.
Attempted to swipe without agreeing to metrics and was not able to get pass it without tapping one of the buttons.
https://recordit.co/IXTl4L4JDB
LGTM
chrisleewilcox
added
QA Passed
chrisleewilcox
added
QA in Progress
chrisleewilcox
added
QA Passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now the metrics are enabled if the user press the confirm button on the opt-in metrics screen
Checklist
Issue
Progresses #https://github.com/MetaMask/mobile-planning/issues/176