Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] Add the "Hold to Reveal" button before revealing an account’s private key #4114

Merged
merged 10 commits into from
Apr 26, 2022
Merged

[FEAT] Add the "Hold to Reveal" button before revealing an account’s private key #4114

merged 10 commits into from
Apr 26, 2022

Conversation

gantunesr
Copy link
Member

Description

As part of the new SRP reveal flow, we developed a "hold to reveal component". We should add that to the private key reveal flow too.

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Progresses mobile-planning#225

@gantunesr gantunesr added needs-qa Any New Features that needs a full manual QA prior to being added to a release. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-accounts labels Apr 18, 2022
@gantunesr gantunesr requested a review from a team as a code owner April 18, 2022 03:39
@gantunesr gantunesr changed the title [FEAT] Add the hold to reveal button before revealing an account’s private key [FEAT] Add the "Hold to Reveal" button before revealing an account’s private key Apr 18, 2022
andreahaku
andreahaku approved these changes Apr 20, 2022
View reviewed changes
Copy link
Member

@andreahaku andreahaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gantunesr gantunesr removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Apr 20, 2022
@cortisiko cortisiko added QA Passed A successful QA run through has been done and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Apr 25, 2022
cortisiko
cortisiko approved these changes Apr 25, 2022
View reviewed changes
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮 🌮 🌮

@gantunesr gantunesr merged commit 4379407 into main Apr 26, 2022
@gantunesr gantunesr deleted the feat/hold-to-reveal-priv-key branch April 26, 2022 00:02
@github-actions github-actions bot locked and limited conversation to collaborators Apr 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andreahaku andreahaku andreahaku approved these changes

@cortisiko cortisiko cortisiko approved these changes

Assignees
No one assigned
Labels
QA Passed A successful QA run through has been done team-accounts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gantunesr @andreahaku @cortisiko