Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.3] [FIX] Add method for crypto that are not in ISO4217 #4131

Merged
merged 13 commits into from
Jun 9, 2022
Merged

[5.3] [FIX] Add method for crypto that are not in ISO4217 #4131

merged 13 commits into from
Jun 9, 2022

Conversation

tommasini
Copy link
Contributor

@tommasini tommasini commented Apr 20, 2022 •
edited

Description
The problem was that if we have the currency conversion selected with one of the Crypto values options, some of them will break our app because they were not listed in the ISO4217 that it's the currency format followed by the FormatNumber

It was also opened a ticket here to try to understand why some crypto codes are acceptable and others not.

Proposed solution
The proposed solution it's when we the currency conversion selected do not meet the iso standards we return the format value currency for example "1 1ST"

Code Impact
Big code impact, the formatCurrency method is used in other files that are used in multiple components and that components are in major transactions screens / transactions modals.

Screenshots or Videos
https://recordit.co/ZG6nNRfvzB

Add relevant testing to ensure the bug is fixed
Test Cases
Case1:

  • Go to settings
  • Go to general
  • Select 1ST - FirstBlood in the currency conversion option
  • Go to browser
  • Browse https://app.uniswap.org/
  • Do one swap
  • Watch the Transaction approval modal (In main would break here)

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Progresses #4107

@tommasini tommasini requested a review from a team as a code owner April 20, 2022 13:11
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

jpcloureiro
jpcloureiro requested changes Apr 20, 2022
View reviewed changes
app/util/confirm-tx.js Outdated Show resolved Hide resolved
app/util/confirm-tx.js Outdated Show resolved Hide resolved
@gantunesr gantunesr changed the title added func with cripto that are not in iso4217, iso used by FormatNumber [FIX] Add method with crypto that are not in ISO4217 Apr 20, 2022
@gantunesr gantunesr added needs-qa Any New Features that needs a full manual QA prior to being added to a release. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Apr 20, 2022
@Fatxx Fatxx added Mobile QA board and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Apr 21, 2022
@plasmacorral plasmacorral added QA in Progress QA has started on the feature. and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Apr 27, 2022
@gantunesr gantunesr changed the title [FIX] Add method with crypto that are not in ISO4217 [FIX] Add method for crypto that are not in ISO4217 Apr 28, 2022
@mobularay mobularay changed the title [FIX] Add method for crypto that are not in ISO4217 [5.3] [FIX] Add method for crypto that are not in ISO4217 May 16, 2022
@plasmacorral plasmacorral added needs-qa Any New Features that needs a full manual QA prior to being added to a release. and removed QA in Progress QA has started on the feature. labels May 31, 2022
@mobularay mobularay changed the title [5.3] [FIX] Add method for crypto that are not in ISO4217 [5.4] [FIX] Add method for crypto that are not in ISO4217 Jun 7, 2022
@plasmacorral plasmacorral added QA in Progress QA has started on the feature. and removed QA in Progress QA has started on the feature. needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Jun 7, 2022
@plasmacorral plasmacorral added the QA Passed A successful QA run through has been done label Jun 7, 2022
@tommasini tommasini merged commit 16d5ad0 into main Jun 9, 2022
@tommasini tommasini deleted the fix/4107-currency-not-formatted branch June 9, 2022 16:23
@tommasini tommasini changed the title [5.4] [FIX] Add method for crypto that are not in ISO4217 [5.3] [FIX] Add method for crypto that are not in ISO4217 Jun 9, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jun 9, 2022
@mobularay mobularay added the release-5.3.0 All PRs that will be included in 5.3.0 release label Jun 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jpcloureiro jpcloureiro jpcloureiro approved these changes

Assignees

@plasmacorral plasmacorral

Labels
QA Passed A successful QA run through has been done release-5.3.0 All PRs that will be included in 5.3.0 release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@tommasini @jpcloureiro @Fatxx @gantunesr @plasmacorral @mobularay @cortisiko