Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

browser improvement #4135

Merged
merged 3 commits into from
Apr 28, 2022
Merged

browser improvement #4135

merged 3 commits into from
Apr 28, 2022

Conversation

blackdevelopa
Copy link
Contributor

@blackdevelopa blackdevelopa commented Apr 20, 2022 •
edited

Description

This PR correctly updates the browser address bar when the origin is changed

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Progresses https://github.com/MetaMask/mobile-planning/issues/185

@blackdevelopa blackdevelopa requested a review from a team as a code owner April 20, 2022 17:15
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@blackdevelopa blackdevelopa added the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Apr 25, 2022
@blackdevelopa blackdevelopa self-assigned this Apr 25, 2022
@blackdevelopa blackdevelopa added the team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead label Apr 25, 2022
sethkfman
sethkfman approved these changes Apr 25, 2022
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chrisleewilcox chrisleewilcox added the QA in Progress QA has started on the feature. label Apr 25, 2022
@cortisiko cortisiko removed the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Apr 26, 2022
chrisleewilcox
chrisleewilcox approved these changes Apr 26, 2022
View reviewed changes
Copy link
Contributor

@chrisleewilcox chrisleewilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chrisleewilcox chrisleewilcox added QA Passed A successful QA run through has been done and removed QA in Progress QA has started on the feature. labels Apr 26, 2022
@gantunesr gantunesr changed the base branch from main to release/5.1.0 April 28, 2022 19:44
@blackdevelopa blackdevelopa merged commit 4addc05 into release/5.1.0 Apr 28, 2022
@blackdevelopa blackdevelopa deleted the improvement/browser-origin branch April 28, 2022 19:51
@github-actions github-actions bot locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jpcloureiro jpcloureiro jpcloureiro left review comments

@chrisleewilcox chrisleewilcox chrisleewilcox approved these changes

@sethkfman sethkfman sethkfman approved these changes

Assignees

@blackdevelopa blackdevelopa

Labels
QA Passed A successful QA run through has been done team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@blackdevelopa @jpcloureiro @chrisleewilcox @sethkfman @cortisiko