Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMPROVEMENT] - iCloud Backup Restriction #4159

Merged
merged 8 commits into from
Apr 28, 2022
Merged

[IMPROVEMENT] - iCloud Backup Restriction #4159

merged 8 commits into from
Apr 28, 2022

Conversation

sethkfman
Copy link
Contributor

@sethkfman sethkfman commented Apr 26, 2022 •
edited by chrisleewilcox

Description

This patch updates the app to exclude files from iCloud backups by default (if the user has not already enabled it). If a user wants to enable it they can do so in OS system settings as pictured below.

Screen Shot 2022-04-26 at 1 34 40 PM

Acceptance Criteria

  • GIVEN as user has their iCloud backup enabled
  • WHEN the users installs MM
  • AND creates a new account
  • THEN the users check's their iCloud backup configuration Settings->iCloud->Manage Storage->Backups->Phone->Show All Apps MM app is toggled OFF

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@sethkfman sethkfman requested a review from a team as a code owner April 26, 2022 19:37
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

gantunesr
gantunesr approved these changes Apr 27, 2022
View reviewed changes
Copy link
Member

@gantunesr gantunesr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think the Podfile.lock changes are not necessary

@sethkfman sethkfman self-assigned this Apr 27, 2022
@sethkfman sethkfman added needs-qa Any New Features that needs a full manual QA prior to being added to a release. Mobile QA board labels Apr 27, 2022
@cortisiko cortisiko added QA Passed A successful QA run through has been done and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Apr 27, 2022
cortisiko
cortisiko approved these changes Apr 27, 2022
View reviewed changes
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this guy is 🌮 🌮🌮🌮

@sethkfman sethkfman merged commit 02dd71c into main Apr 28, 2022
@sethkfman sethkfman deleted the improvement/ios_backups branch April 28, 2022 15:10
@github-actions github-actions bot locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cortisiko cortisiko cortisiko approved these changes

@gantunesr gantunesr gantunesr approved these changes

Assignees

@sethkfman sethkfman

Labels
QA Passed A successful QA run through has been done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sethkfman @cortisiko @gantunesr