Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.2] Copy to clipboard for Android version 9 and below #4170

Merged
merged 9 commits into from
May 16, 2022
Merged

[5.2] Copy to clipboard for Android version 9 and below #4170

merged 9 commits into from
May 16, 2022

Conversation

blackdevelopa
Copy link
Contributor

@blackdevelopa blackdevelopa commented Apr 27, 2022 •
edited

Description

This PR should prevents android versions less than ten from copying SRP to clipboard

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Progresses https://github.com/MetaMask/mobile-planning/issues/243

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@blackdevelopa blackdevelopa force-pushed the improvement/supportedAndroidVersion branch from c034f74 to 817ba4a Compare April 28, 2022 12:52
@blackdevelopa blackdevelopa marked this pull request as ready for review April 29, 2022 10:16
@blackdevelopa blackdevelopa requested a review from a team as a code owner April 29, 2022 10:16
@blackdevelopa blackdevelopa self-assigned this Apr 29, 2022
@blackdevelopa blackdevelopa added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label May 2, 2022
@blackdevelopa blackdevelopa force-pushed the improvement/supportedAndroidVersion branch from ff4ccff to b8a4f5e Compare May 3, 2022 10:57
@blackdevelopa blackdevelopa force-pushed the improvement/supportedAndroidVersion branch from b8a4f5e to bd99b5b Compare May 4, 2022 15:27
sethkfman
sethkfman approved these changes May 5, 2022
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sethkfman sethkfman removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label May 6, 2022
@cortisiko cortisiko added the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label May 7, 2022
@sethkfman sethkfman changed the title Copy to clipboard for Android version 9 and below [5.2] Copy to clipboard for Android version 9 and below May 10, 2022
@plasmacorral plasmacorral added QA'd - Issues Found QA has been complete, however issues have been discovered that need to be addressed and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels May 12, 2022
@plasmacorral
Copy link
Contributor

plasmacorral commented May 12, 2022 •
edited

I am able to copy both private key and SRP running android 6 and 8.

@plasmacorral plasmacorral added QA in Progress QA has started on the feature. QA Passed A successful QA run through has been done and removed QA'd - Issues Found QA has been complete, however issues have been discovered that need to be addressed QA in Progress QA has started on the feature. labels May 13, 2022
@plasmacorral
Copy link
Contributor

Able to copy values in Android 10, 11, 12 and iOS.
Copy button is not available in Android versions 6, 7, 8, 9.

@plasmacorral plasmacorral added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label May 13, 2022
gantunesr
gantunesr approved these changes May 14, 2022
View reviewed changes
Copy link
Member

@gantunesr gantunesr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blackdevelopa blackdevelopa removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label May 16, 2022
@blackdevelopa blackdevelopa merged commit 9705266 into main May 16, 2022
@blackdevelopa blackdevelopa deleted the improvement/supportedAndroidVersion branch May 16, 2022 16:36
@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2022
@mobularay mobularay added the release-5.2.0 Issues/PRs confirmed for prod release 5.2.0 label May 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sethkfman sethkfman sethkfman approved these changes

@gantunesr gantunesr gantunesr approved these changes

Assignees

@blackdevelopa blackdevelopa

@plasmacorral plasmacorral

Labels
QA Passed A successful QA run through has been done release-5.2.0 Issues/PRs confirmed for prod release 5.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@blackdevelopa @plasmacorral @sethkfman @gantunesr @cortisiko @mobularay