[FIX] can't load dapp with unknown network #4173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
tommasini
commented
Apr 27, 2022
|
This issue its fixed on this PR |
tommasini
changed the title
tommasini
added
the
needs-dev-review
…ps://github.com/MetaMask/metamask-mobile into fix/3391-can-not-load-dapp-with-unknown-network
sethkfman
reviewed
Jun 23, 2022
Fatxx
added
needs-qa
chrisleewilcox
added
QA in Progress
|
Scenario 1: https://recordit.co/81O3dxxE0V |
chrisleewilcox
added
QA Passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The problem was when we browse "totee.xyz" or "ebisusbay.xyz" and we are in the custom network it gives an EnsIpfsResolver error.
That error comes from the fact that we were verifying if the domain it's an ENS and actually is a top-level domain ending in '.xyz'.
Proposed Solution
The proposed solution it's that when the ens throws an error because doesn't have an ens for the custom chain id and ends in ".xyz" and ".test", we add it to the ensIgnoreList and return the full URL "https://ebisusbay.xyz"
Also changed the "substr" deprecated javascript method for "slice".
Code Impact
Low
Screenshots/Recordings
Solution:
https://recordit.co/4zp4r2XzjG
Test Cases
Case1:
Checklist
Issue
Progresses #3391