Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] - audit dependency exclusion #4183

Merged
merged 1 commit into from
Apr 28, 2022
Merged

[FIX] - audit dependency exclusion #4183

merged 1 commit into from
Apr 28, 2022

Conversation

sethkfman
Copy link
Contributor

  • added yarn audit exclusion
  • doesn't seem to impact the code base
  • the issue references a patch for node-fetch: 2.6.7 which we have in the resolutions in the package.json

@sethkfman
excluded audit because no available patch, does not seem to impact br…
8f0b8f1 
…owser as we don't supprot cookies, controllers calls do not pass cookies
@sethkfman sethkfman requested a review from a team as a code owner April 28, 2022 22:29
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

gantunesr
gantunesr approved these changes Apr 28, 2022
View reviewed changes
Copy link
Member

@gantunesr gantunesr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sethkfman sethkfman merged commit ca6e8a8 into main Apr 28, 2022
@sethkfman sethkfman deleted the fix/audit-warning branch April 28, 2022 22:43
@github-actions github-actions bot locked and limited conversation to collaborators Apr 28, 2022
@tommasini tommasini added the release-5.2.0 Issues/PRs confirmed for prod release 5.2.0 label May 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gantunesr gantunesr gantunesr approved these changes

Assignees
No one assigned
Labels
release-5.2.0 Issues/PRs confirmed for prod release 5.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sethkfman @gantunesr @tommasini