Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX][5.2] Add support for env variable for MM_HOMEPAGE #4303

Merged
merged 3 commits into from
May 16, 2022
Merged

[FIX][5.2] Add support for env variable for MM_HOMEPAGE #4303

merged 3 commits into from
May 16, 2022

Conversation

Fatxx
Copy link
Contributor

@Fatxx Fatxx commented May 13, 2022

Description

Add support for MM homepage environment variable.

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Progresses #???

@Fatxx Fatxx requested a review from a team as a code owner May 13, 2022 15:15
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

sethkfman
sethkfman approved these changes May 13, 2022
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Fatxx Fatxx merged commit 9855323 into main May 16, 2022
@Fatxx Fatxx deleted the fix/env-var-dapp-homepage branch May 16, 2022 17:34
@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2022
@mobularay mobularay added the release-5.2.0 Issues/PRs confirmed for prod release 5.2.0 label May 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rickycodes rickycodes rickycodes approved these changes

@sethkfman sethkfman sethkfman approved these changes

Assignees
No one assigned
Labels
release-5.2.0 Issues/PRs confirmed for prod release 5.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Fatxx @rickycodes @sethkfman @mobularay