Hide remember me

[owencraston]

Description

• Remove remember me as an option for new users
• The key here is new users. Users who have already enabled remember me should not be affected by this change.
• This simply hides the front end that allows for remember me to be toggled on.
• Based on the feedback below, remember me will be something the user can turn on in settings and is now intended more for developers
• I also made a LoginOptionsSwitch that handles if what login option should be rendered into its own component since it was repeated in several files
• biometrics is always going to be the higher priority option for login. we will only show remember me as an option if its enabled in settings and biometrics are disabled

Future improvements

• Once the auth refactor ships, we can move ALL of the biometric logic (state on weather to show biometric or not, handle errors etch) into this component.
• The main blocker from doing this now is this handleRejectedOsBiometricPrompt which calls updateBiometryChoice
• the updateBiometryChoice function is repeated in each of these files

Checklist

• There is a related GitHub issue
• Tests are included if applicable
• Any added code is fully documented

#4194
Progresses #4194

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[blackdevelopa]

I didn't run this code and my comments are simply nitpicking.

[gantunesr]

Some general notes on the PR,

• If this has an impact in the UI/UX, you should add a screenshot/recording of the before and after for QA and future references
• Don't use the keyword Resolves, GH closes the issue related to the PR when it is merged, and this can lead to some confusion on our product boards. Use Progresses instead.

Regarding the code, it looks good to me in the scope of my knowledge about the "Remember Me" epic. I'm not sure if you want @sethkfman to review it since he has more context on the Auth Refactor. If not, and @blackdevelopa agrees, we can approve it and pass it to QA after the failing test (LoginWithBiometricsSwitch) is solved.

[gantunesr]

LGTM. @blackdevelopa let me know if you have any objection.

@owencraston will solve the failing test before moving it to QA

[AlexJupiter]

Suggested route forward to still allow this feature to be used by developers.

1. Still hide this feature for new users, but provide the ability for someone to turn Remember Me on via a toggle on the Security & Privacy settings section of the app.
2. This toggle should be placed underneath the "Unlock with Face ID?" toggle and be named "Unlock with Remember Me?". It should also have the subtitle "Turn on at your own risk, since this feature gives anyone with access to your phone also access to MetaMask without any additional security."
3. This toggle should be turned off by default on new installations
4. We should record an event when this toggle is turned on Remember Me Toggled On and an event for when the toggle is turned off Remember Me Toggled Off

@jakehaugen could you briefly check my copy suggestion please? Thank you :).

cc. @plasmacorral @gantunesr @sethkfman @owencraston

[AlexJupiter]

@owencraston slight improvement to the copy @jakehaugen and I have discussed:
Title: Allow "Remember me"
Subtitle: Turn on at your own risk. When "Remember me" is on, it gives anyone access to your MetaMask if they can access your phone.

Since this should just enable the checkbox again, and not actually turn it on, we think this copy improvement is necessary. Any thought let us know!

[owencraston]

I ripped the translations out of this crowdin PR