Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Detox]fix addressbook and browser test #4331

Merged
merged 3 commits into from
May 16, 2022
Merged

[Detox]fix addressbook and browser test #4331

merged 3 commits into from
May 16, 2022

Conversation

cortisiko
Copy link
Member

Description

Write a short description of the changes included in this pull request.

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Screenshots/Recordings

If applicable, add screenshots or recordings to visualize the changes

Issue

Progresses #???

@cortisiko cortisiko added No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels May 16, 2022
@cortisiko cortisiko requested a review from a team as a code owner May 16, 2022 13:59
gantunesr
gantunesr approved these changes May 16, 2022
View reviewed changes
Copy link
Member

@gantunesr gantunesr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cortisiko cortisiko merged commit e6a2576 into main May 16, 2022
@cortisiko cortisiko deleted the detox/fix-addressbook-and-browser branch May 16, 2022 17:14
@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2022
@mobularay mobularay added the release-5.2.0 Issues/PRs confirmed for prod release 5.2.0 label May 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gantunesr gantunesr gantunesr approved these changes

Assignees
No one assigned
Labels
needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. release-5.2.0 Issues/PRs confirmed for prod release 5.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cortisiko @gantunesr @mobularay