Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.2][FIX] Fix homepage scripts and env import #4344

Merged
merged 1 commit into from
May 16, 2022
Merged

[5.2][FIX] Fix homepage scripts and env import #4344

merged 1 commit into from
May 16, 2022

Conversation

Fatxx
Copy link
Contributor

@Fatxx Fatxx commented May 16, 2022

Description

Hotfix injectHomepageScripts method into RPC middleware and remove optional chaining this functionality does not work for process.env variables.

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Screenshots/Recordings

If applicable, add screenshots or recordings to visualize the changes

Issue

Progresses #???

@Fatxx Fatxx requested a review from a team as a code owner May 16, 2022 19:17
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Fatxx Fatxx changed the base branch from release/5.2.0 to main May 16, 2022 19:26
Cal-L
Cal-L approved these changes May 16, 2022
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Fatxx Fatxx merged commit fa67808 into main May 16, 2022
@Fatxx Fatxx deleted the hotfix/inject-favorites-script branch May 16, 2022 19:35
@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2022
@mobularay mobularay added the release-5.2.0 Issue or pull request that will be included in release 5.2.0 label May 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Cal-L Cal-L Cal-L approved these changes

Assignees
No one assigned
Labels
release-5.2.0 Issue or pull request that will be included in release 5.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Fatxx @Cal-L @mobularay