Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix subtitle mapping #4349

Merged
merged 5 commits into from
May 17, 2022
Merged

Fix subtitle mapping #4349

merged 5 commits into from
May 17, 2022

Conversation

rickycodes
Copy link
Member

@rickycodes rickycodes commented May 16, 2022

this broke partly because of #4157 and partly because we're using these keys for not translations

this fixes it. I'll have to see if there's a way we can mark these keys to not be translated

@rickycodes rickycodes requested a review from a team as a code owner May 16, 2022 23:50
@rickycodes rickycodes force-pushed the bugfix/fix-subtitle-mapping branch from 81c1a9e to 37c698b Compare May 16, 2022 23:55
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮 🌮 🌮

@cortisiko cortisiko merged commit 9d8e0a0 into main May 17, 2022
@cortisiko cortisiko deleted the bugfix/fix-subtitle-mapping branch May 17, 2022 01:37
@github-actions github-actions bot locked and limited conversation to collaborators May 17, 2022
@rickycodes rickycodes changed the title Bugfix/fix subtitle mapping Fix subtitle mapping May 17, 2022
@mobularay mobularay added the release-5.2.0 Issues/PRs confirmed for prod release 5.2.0 label May 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-5.2.0 Issues/PRs confirmed for prod release 5.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants