Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.4] Feature/3157 token detection v2 merge #4388

Merged
merged 47 commits into from
Jul 12, 2022
Merged

[5.4] Feature/3157 token detection v2 merge #4388

merged 47 commits into from
Jul 12, 2022

Conversation

Cal-L
Copy link
Contributor

@Cal-L Cal-L commented May 24, 2022 •
edited

Description

#3157

Video here - https://www.notion.so/5-4-0-8a73698dde22435ebf1cdbdcd934415f#9acb0b01e4624f54a634dbf1447e38e5

Original PR - #4096

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Screenshots/Recordings

If applicable, add screenshots or recordings to visualize the changes

Issue

Progresses #???

@Cal-L Cal-L requested a review from a team as a code owner May 24, 2022 00:38
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Cal-L Cal-L mentioned this pull request May 24, 2022
Closed
@Cal-L Cal-L changed the title Feature/3157 token detection v2 merge [5.4] Feature/3157 token detection v2 merge May 24, 2022
@Cal-L Cal-L added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) needs-qa Any New Features that needs a full manual QA prior to being added to a release. Mobile QA board labels May 24, 2022
@chrisleewilcox chrisleewilcox added QA in Progress QA has started on the feature. and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels May 25, 2022
gantunesr
gantunesr approved these changes May 26, 2022
View reviewed changes
Copy link
Member

@gantunesr gantunesr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chrisleewilcox chrisleewilcox self-assigned this Jun 1, 2022
@chrisleewilcox chrisleewilcox added the QA'd - Issues Found QA has been complete, however issues have been discovered that need to be addressed label Jun 7, 2022
@chrisleewilcox
Copy link
Contributor

chrisleewilcox commented Jun 7, 2022 •
edited

Adding remaining issues here.....

#1. Token Import sheet does not scroll down (swipe up) , cannot see all tokens detected

  • Wallet view > tap "{count} new tokens found in this account" with a count high enough to have tokens listed on the token sheet beyond what can fit on the token sheet for viewing.
  • swipe up to scroll down

You will see that the token import sheet does not scroll down when you swipe up.
https://recordit.co/fpw4EkS6vb

gantunesr
gantunesr approved these changes Jun 28, 2022
View reviewed changes
Copy link
Member

@gantunesr gantunesr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sethkfman
updated url for reporting invalid phishing site (#4485)
f5e9235 
* updated url for reporting invalid phishing site

* removed console log

* Update app/components/Views/BrowserTab/index.js

Co-authored-by: Gustavo Antunes <gantunes@uc.cl>

* merge conflict

* added urls to constants and refactored add to allow list logic

* fixed yarn.lock file

* useEffect chage

* updated logic to fix browser blocklist override

* using ref to access props allow list

* sync with token detect branch

* update yarn.lock

Co-authored-by: Gustavo Antunes <gantunes@uc.cl>
@chrisleewilcox chrisleewilcox added the QA in Progress QA has started on the feature. label Jun 29, 2022
Cal-L added 16 commits June 29, 2022 08:59
@Cal-L
Merge branch 'main' into feature/3157-token-detection-v2-merge
5b08559
@Cal-L
Fix setting default account while reopening app after first session
fcfb2d9
@Cal-L
Update whats new modal with current version (5.2.0) to show
1c06a66
@Cal-L
Update token detection whats new image
14f0a8e
@Cal-L
Update whats new copy
78abcf2
@Cal-L
Change whats new to upgrade only
3bc3aa4
@Cal-L
Up whats new version 5.2.0
347e8b7
@Cal-L
Fix frozen state caused by whats new modal
e68a894
@Cal-L
Update version to 5.4.0
c44ed2d
@Cal-L
Merge branch 'feature/3157-token-detection-v2-merge' of https://githu…
d27086e 
…b.com/MetaMask/metamask-mobile into fix/4607-whats-new-frozen-state
@Cal-L
Update iOS version
469fab8
@Cal-L
Merge branch 'feature/3157-token-detection-v2-merge' of https://githu…
7add98e 
…b.com/MetaMask/metamask-mobile into fix/4607-whats-new-frozen-state
@Cal-L
Refactor Whats New modal to be part of React Navigation. Remove confl…
2994041 
…ict between onboarding wizard and whats new modal
@Cal-L
Fix highlighted wallet tab in drawer
cf7e783
@Cal-L
Merge from main. WIP - Fix whats new modal
84f1b5a
@Cal-L
Merge in whats new modal fix
181366a
@chrisleewilcox chrisleewilcox added QA Passed A successful QA run through has been done and removed QA'd - Issues Found QA has been complete, however issues have been discovered that need to be addressed QA in Progress QA has started on the feature. labels Jul 11, 2022
chrisleewilcox
chrisleewilcox approved these changes Jul 11, 2022
View reviewed changes
Copy link
Contributor

@chrisleewilcox chrisleewilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Cal-L
Merge branch 'main' of https://github.com/MetaMask/metamask-mobile in…
1271757 
…to feature/3157-token-detection-v2-merge
@Cal-L Cal-L merged commit 69b7760 into main Jul 12, 2022
@Cal-L Cal-L deleted the feature/3157-token-detection-v2-merge branch July 12, 2022 01:17
@github-actions github-actions bot locked and limited conversation to collaborators Jul 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chrisleewilcox chrisleewilcox chrisleewilcox approved these changes

@gantunesr gantunesr gantunesr approved these changes

Assignees

@chrisleewilcox chrisleewilcox

Labels
QA Passed A successful QA run through has been done release-5.4.0 PRs for v5.4.0 release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Cal-L @chrisleewilcox @bschorchit @omnat @gantunesr @sethkfman