[PS UI] FaviconAvatar component #4414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Cal-L
reviewed
Jun 22, 2022
app/component-library/components/FaviconAvatar/FaviconAvatar.tsx
Outdated
Show resolved
Hide resolved
Cal-L
added
the
needs-dev-review
jpcloureiro
force-pushed
the
feat/redesign-favicon-avatar
branch
from
70eb149
to
5e6c604
Compare
georgewrmarshall
approved these changes
Jun 24, 2022
There was a problem hiding this comment.
One tiny nit and one comment about adding a test for the error state otherwise smashed it out of the park 💯
- verified component code to the best of my ability
- verified unit tests (need to update snapshots otherwise working)
- verified all stories in storybook
- verified all knobs and knob options work in storybook
- verified markdown documentation
|
@Akatori-Design checkout current fallback idea for this component. Also in description of this PR
|
Co-authored-by: George Marshall <george.marshall@consensys.net>
…to feat/redesign-favicon-avatar
Cal-L
added
release-5.4.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
FaviconAvatar component implementation, for the Permission System UI.
Default
With Error
Checklist
Screenshots/Recordings
If applicable, add screenshots or recordings to visualize the changes
Issue
Progresses #4104