-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMPROVEMENT] Address Verification #4418
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also add the same validation in Views/Send/index.js
screen?
@Fatxx I don't see any validation logic in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested these Incorrect check sum addressed:
0xa54D3c09E34aC96807c1CC397404bF2B98DC4eFb
0x87187657b35f461d0ceEc338d9B8e944A193afe2
on the send flow and also on the add contact view. I also generated QR codes for the above addresses and tested with them. See QR codes here and here. I tested upper cased addresses and lower cased addresses.
I tested scanning a keystone address QR code and I was able to successfully send to that address.
Finally I did sanity checks on:
scanning a request QR code. The correct address received the funds
Scanning an extension QR code for a couple of my accounts. I had no issues
QA passed! 🌮 🌮
Description
Improve address verification in SendFlow,
0x87187657b35f461d0ceEc338d9B8e944A193afe2
0x87187657b35F461D0Ceec338d9b8E944a193aFE2
Checklist
Screenshots/Recordings
Issue
Progresses https://github.com/MetaMask/mobile-planning/issues/288