Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor transaction component #4420

Merged
merged 13 commits into from
Jul 8, 2022
Merged

Refactor transaction component #4420

merged 13 commits into from
Jul 8, 2022

Conversation

blackdevelopa
Copy link
Contributor

Description

Abstracts the gas polling logic from the transaction component.

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Screenshots/Recordings

If applicable, add screenshots or recordings to visualize the changes

Issue

Progresses #???

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@blackdevelopa blackdevelopa self-assigned this May 30, 2022
@blackdevelopa blackdevelopa marked this pull request as ready for review June 2, 2022 09:06
@blackdevelopa blackdevelopa requested a review from a team as a code owner June 2, 2022 09:06
@blackdevelopa blackdevelopa changed the title Refactor transaction component [WIP] Refactor transaction component Jun 2, 2022
@blackdevelopa blackdevelopa added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jun 2, 2022
@sethkfman sethkfman added release-5.3.0 All PRs that will be included in 5.3.0 release release-5.4.0 PRs for v5.4.0 release and removed release-5.4.0 PRs for v5.4.0 release release-5.3.0 All PRs that will be included in 5.3.0 release labels Jun 14, 2022
@sethkfman sethkfman added the No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. label Jun 28, 2022
@sethkfman
Copy link
Contributor

@cortisiko @chrisleewilcox FYI this doesn't need QA but wanted you to be aware

sethkfman
sethkfman approved these changes Jul 5, 2022
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sethkfman sethkfman removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jul 5, 2022
@chrisleewilcox chrisleewilcox self-assigned this Jul 6, 2022
@chrisleewilcox
Copy link
Contributor

chrisleewilcox commented Jul 7, 2022 •
edited

Ran detox automated test. All test pass except deeplink and contract-nickname test fail but those automation test need to be updated.

chrisleewilcox
chrisleewilcox approved these changes Jul 7, 2022
View reviewed changes
Copy link
Contributor

@chrisleewilcox chrisleewilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT.

@chrisleewilcox chrisleewilcox added the QA Passed A successful QA run through has been done label Jul 7, 2022
@blackdevelopa blackdevelopa merged commit 738ef08 into main Jul 8, 2022
@blackdevelopa blackdevelopa deleted the refactor/240-transaction branch July 8, 2022 18:28
@github-actions github-actions bot locked and limited conversation to collaborators Jul 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chrisleewilcox chrisleewilcox chrisleewilcox approved these changes

@sethkfman sethkfman sethkfman approved these changes

Assignees

@chrisleewilcox chrisleewilcox

@blackdevelopa blackdevelopa

Labels
No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. QA Passed A successful QA run through has been done release-5.4.0 PRs for v5.4.0 release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@blackdevelopa @sethkfman @chrisleewilcox