Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.5] Keystone: fix 2 bugs #4430

Merged
merged 3 commits into from
Sep 20, 2022
Merged

Conversation

soralit
Copy link
Contributor

@soralit soralit commented Jun 1, 2022

Description

This PR fixed 2 bugs with Keystone:

  1. keystone accounts will disappear when reset password.
  2. keystone accounts page will increase 1 when scanning wrong wallet sync qrcode.

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Screenshots/Recordings

If applicable, add screenshots or recordings to visualize the changes

Issue

Progresses https://github.com/MetaMask/qr-hardware-wallets/issues/7
Progresses https://github.com/MetaMask/qr-hardware-wallets/issues/6

@soralit soralit requested a review from a team as a code owner June 1, 2022 09:02
@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2022

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Member

@gantunesr gantunesr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @soralit! I'm leaving some questions for the moment

app/components/Views/ResetPassword/index.js Outdated Show resolved Hide resolved
@gantunesr gantunesr added needs-qa Any New Features that needs a full manual QA prior to being added to a release. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Mobile QA board labels Jun 9, 2022
@AlexJupiter AlexJupiter changed the title Keystone: fix 2 bugs [5.5] Keystone: fix 2 bugs Jun 10, 2022
@soralit
Copy link
Contributor Author

soralit commented Jun 13, 2022

Hi @gantunesr , PR was updated. I found the restoring process was duplicated in two place so I combined them into one, what do you think?

@cortisiko cortisiko added QA in Progress QA has started on the feature. and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Jun 16, 2022
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@soralit I am unable to log in after a password change. Basically, when I attempt to change my password with biometrics log-in disabled I get an error “invalid password”.

To reproduce:

import your wallet
go to the privacy and security page
tap on the “change password” button
enter your current password to proceed
now you should be taken to the create password screen
enter a new password
before creating the new password toggle off “log in with biometrics”
proceed and create that new password
After the password change was successful
kill the app
relaunch the app
login with your new password. Notice the error

I reproduced without binding my keystone device: http://recordit.co/jt2b4IjCxm

And after I bind my keystone device: http://recordit.co/iKkwuYgxpP

@cortisiko cortisiko added QA'd - Issues Found QA has been complete, however issues have been discovered that need to be addressed and removed QA in Progress QA has started on the feature. labels Jul 5, 2022
@AlexJupiter
Copy link

Hey @soralit any update on this at all? :)

@soralit
Copy link
Contributor Author

soralit commented Aug 18, 2022

Hi @AlexJupiter @cortisiko , really sorry for the late reply. I just fixed this issue. Thanks for your feedback.

@plasmacorral plasmacorral self-assigned this Aug 18, 2022
@plasmacorral plasmacorral added needs-qa Any New Features that needs a full manual QA prior to being added to a release. and removed QA'd - Issues Found QA has been complete, however issues have been discovered that need to be addressed labels Aug 18, 2022
Copy link
Member

@gantunesr gantunesr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cortisiko cortisiko added QA Passed A successful QA run through has been done and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Sep 20, 2022
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is 🌮 🌮

@cortisiko cortisiko merged commit de3c471 into MetaMask:main Sep 20, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Sep 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
QA Passed A successful QA run through has been done release-5.8.0 team-accounts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants