Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get added subtitles working #4478

Merged
merged 6 commits into from
Jun 8, 2022
Merged

Get added subtitles working #4478

merged 6 commits into from
Jun 8, 2022

Conversation

rickycodes
Copy link
Member

@rickycodes rickycodes commented Jun 8, 2022 •
edited

This gets subtitles working for all languages using the newly translated subtitle files in: #4262

those very files were merged in #4477

@rickycodes rickycodes requested a review from a team as a code owner June 8, 2022 14:04
@rickycodes rickycodes added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Jun 8, 2022
@cortisiko cortisiko added QA in Progress QA has started on the feature. and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Jun 8, 2022
owencraston
owencraston approved these changes Jun 8, 2022
View reviewed changes
Copy link
Contributor

@owencraston owencraston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cortisiko cortisiko removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jun 8, 2022
cortisiko
cortisiko approved these changes Jun 8, 2022
View reviewed changes
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮 🌮 🌮

@cortisiko cortisiko added QA Passed A successful QA run through has been done and removed QA in Progress QA has started on the feature. labels Jun 8, 2022
@rickycodes rickycodes changed the title Feature/crowdin subtitles secretPhrase subtitles for all languages Jun 8, 2022
@rickycodes rickycodes changed the title secretPhrase subtitles for all languages Get added subtitles working Jun 8, 2022
@rickycodes rickycodes merged commit 19d3657 into main Jun 8, 2022
@rickycodes rickycodes deleted the feature/crowdin-subtitles branch June 8, 2022 22:14
@github-actions github-actions bot locked and limited conversation to collaborators Jun 8, 2022
@cortisiko cortisiko added the release-5.3.0 All PRs that will be included in 5.3.0 release label Jun 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cortisiko cortisiko cortisiko approved these changes

@owencraston owencraston owencraston approved these changes

Assignees
No one assigned
Labels
QA Passed A successful QA run through has been done release-5.3.0 All PRs that will be included in 5.3.0 release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rickycodes @cortisiko @owencraston