Fix WalletConnect Icon on connect screen #4495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrepimenta
added
needs-dev-review
omnat
added
Sev2-normal
cortisiko
added
QA in Progress
cortisiko
approved these changes
Jun 15, 2022
There was a problem hiding this comment.
I tested connecting to these dapps through walletconnect:
rariable
opensea
compound.finance
pancake swap
uniswap
olympusdao.finance
I tested opening the dapp in the native browser (chrome/Safari) then connecting via walletconnect
I also test opening the dapp on a desktop browser then scanning the WC QR code using the in app camera to connect to the dapp.
In both scenarios I see the dapp icon on the connect modal.
✅ ✅ This is QA pass!!
cortisiko
added
QA Passed
gantunesr
approved these changes
Jun 15, 2022
cortisiko
removed
the
needs-dev-review
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use WalletConnect icon field on connect screen
How to test: Test multiple websites that use WalletConnect, they all should work and they all should show an Icon on the connect modal