Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add decimals optional prop to keypad in onramp amount view #4498

Merged
merged 8 commits into from
Jul 12, 2022
Merged

Add decimals optional prop to keypad in onramp amount view #4498

merged 8 commits into from
Jul 12, 2022

Conversation

wachunei
Copy link
Member

This PR adds the decimals prop to Keypad component and uses as fallback when the currency is not found in the CURRENCIES list.

@wachunei wachunei requested a review from a team as a code owner June 14, 2022 18:48
@wachunei wachunei added the release-5.4.0 PRs for v5.4.0 release label Jun 22, 2022
alaahd
alaahd approved these changes Jun 30, 2022
View reviewed changes
Copy link
Contributor

@alaahd alaahd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

gantunesr
gantunesr approved these changes Jul 6, 2022
View reviewed changes
Copy link
Member

@gantunesr gantunesr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gantunesr gantunesr added the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Jul 6, 2022
@wachunei wachunei added needs-qa Any New Features that needs a full manual QA prior to being added to a release. QA Passed A successful QA run through has been done and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Jul 8, 2022
@cortisiko cortisiko removed the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Jul 12, 2022
@cortisiko cortisiko merged commit 749798e into main Jul 12, 2022
@cortisiko cortisiko deleted the feature/onramp-add-decimals-to-keypad branch July 12, 2022 14:21
@github-actions github-actions bot locked and limited conversation to collaborators Jul 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alaahd alaahd alaahd approved these changes

@gantunesr gantunesr gantunesr approved these changes

Assignees
No one assigned
Labels
QA Passed A successful QA run through has been done release-5.4.0 PRs for v5.4.0 release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@wachunei @alaahd @gantunesr @cortisiko