Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed Android activity launch mode #4527

Merged
merged 3 commits into from
Jul 11, 2022
Merged

Changed Android activity launch mode #4527

merged 3 commits into from
Jul 11, 2022

Conversation

sethkfman
Copy link
Contributor

Description

Updated the launch mode in Android

Checklist

  • [NA] There is a related GitHub issue
  • [NA] Tests are included if applicable
  • [NA] Any added code is fully documented

@sethkfman sethkfman requested a review from a team as a code owner June 17, 2022 16:31
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sethkfman sethkfman self-assigned this Jun 17, 2022
@sethkfman sethkfman added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Priority - High Task with high priority labels Jun 17, 2022
@sethkfman sethkfman changed the title changed launch mode to singleInstance Changed Android activity launch mode Jun 17, 2022
@sethkfman sethkfman added the release-5.4.0 PRs for v5.4.0 release label Jun 17, 2022
Copy link
Member

@rickycodes rickycodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sethkfman sethkfman added needs-qa Any New Features that needs a full manual QA prior to being added to a release. Mobile QA board and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Jun 30, 2022
@cortisiko cortisiko added QA in Progress QA has started on the feature. and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Jul 6, 2022
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scenarios I covered:

  • I tested using the hardware back button at various points in the app: Going through the swaps flow then tapping on the hardware back button until I get to the wallet view. When I got to the wallet view I hit the home button then reopened the app, and tested the hardware back button on the send flow, While on the browser view, the Settings view

  • I also tested using the in-app back button: tested this on the settings view, On the send flow, on the swaps flow

  • I tested logging out of the app, landing on the log-in view then tapping the hardware back button. I was not taken back to the wallet view

  • I tested deep links with the app closed and in the background. Wallet connect deep links as well.
    I tested using the hardware back button as well as the in-app back button on the change password view.

  • I made a couple of transactions.

this is 👍

@cortisiko cortisiko added QA Passed A successful QA run through has been done and removed QA in Progress QA has started on the feature. labels Jul 6, 2022
@cortisiko cortisiko merged commit a23cabc into main Jul 11, 2022
@cortisiko cortisiko deleted the fix/launch-mode branch July 11, 2022 19:22
@github-actions github-actions bot locked and limited conversation to collaborators Jul 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Priority - High Task with high priority QA Passed A successful QA run through has been done release-5.4.0 PRs for v5.4.0 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants