Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Component/4084 tab bar #4549

Merged
merged 21 commits into from
Jun 29, 2022
Merged

Component/4084 tab bar #4549

merged 21 commits into from
Jun 29, 2022

Conversation

Cal-L
Copy link
Contributor

@Cal-L Cal-L commented Jun 21, 2022 •
edited

Description

#4084

Default
image

V1 is designed specifically for React Navigation V5. In future versions, we may make this more generic.

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Screenshots/Recordings

If applicable, add screenshots or recordings to visualize the changes

Issue

Progresses #???

Cal-L added 17 commits June 7, 2022 10:12
@Cal-L
[WIP] Push up icon changes
2187252
@Cal-L
Introduce assets
d7c4f35
@Cal-L
Create script to generate Icon types based on icons in assets directory
c3deb2f
@Cal-L
Change Icon component to use SVGs. Create script to auto generate SVG…
116afca 
… types. Use an svg transformer to allow for importing SVGs as components
@Cal-L
Update ignores on Icon.assets
3422e16
@Cal-L
Update generate-assets script to add ignores
fdd083e
@Cal-L
Remove icon test - SVG mock issue. Update Icon docs with color prop
f20890b
@Cal-L
Fix useStyles for other components
e5c2953
@Cal-L
Merge branch 'main' of https://github.com/MetaMask/metamask-mobile in…
79b3dad 
…to component/4221-icon
@Cal-L
Update Icon README
7b39f85
@Cal-L
Create tab bar item
84c952e
@Cal-L
Create Tab Bar
be59c57
@Cal-L
Update types
3ed086d
@Cal-L
Update tab bar item style
613cea2
@Cal-L
Merge branch 'component/4085-tab-bar-item' of https://github.com/Meta…
f48d1f6 
…Mask/metamask-mobile into component/4084-tab-bar
@Cal-L
Refine story
dc17bbb
@Cal-L
Merge branch 'component/4085-tab-bar-item' of https://github.com/Meta…
c05db85 
…Mask/metamask-mobile into component/4084-tab-bar
@Cal-L Cal-L requested a review from a team as a code owner June 21, 2022 06:29
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Cal-L Cal-L changed the base branch from main to component/4085-tab-bar-item June 21, 2022 18:00
@Cal-L Cal-L added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jun 23, 2022
@jpcloureiro jpcloureiro removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jun 28, 2022
Base automatically changed from component/4085-tab-bar-item to main June 28, 2022 23:34
@Cal-L Cal-L merged commit 6fe434e into main Jun 29, 2022
@Cal-L Cal-L deleted the component/4084-tab-bar branch June 29, 2022 05:54
@github-actions github-actions bot locked and limited conversation to collaborators Jun 29, 2022
@Cal-L Cal-L added the release-5.4.0 PRs for v5.4.0 release label Jul 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jpcloureiro jpcloureiro jpcloureiro approved these changes

Assignees
No one assigned
Labels
release-5.4.0 PRs for v5.4.0 release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Cal-L @jpcloureiro