Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for env variable to customise the simulator that gets launched on iOS #4554

Merged
merged 7 commits into from
Jun 29, 2022

Conversation

rickycodes
Copy link
Member

Description

This allows the consumer to specify a different simulator via:

IOS_SIMULATOR="iPhone 13 Pro Max" yarn start:ios

@rickycodes rickycodes requested a review from a team as a code owner June 21, 2022 16:30
@rickycodes rickycodes added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jun 21, 2022
@rickycodes rickycodes added No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. and removed No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. labels Jun 21, 2022
Copy link
Member

@wachunei wachunei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wachunei wachunei removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jun 24, 2022
@rickycodes rickycodes merged commit 0c964f1 into main Jun 29, 2022
@rickycodes rickycodes deleted the feature/customize-ios-sim branch June 29, 2022 19:24
@github-actions github-actions bot locked and limited conversation to collaborators Jun 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants