Fix color types

[Cal-L]

Description

#4601

How it looks now

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Progresses #???

Checklist

• There is a related GitHub issue
• Tests are included if applicable
• Any added code is fully documented

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[wachunei]

I don't think we should import from nested files , ie: import { ThemeColors } from '@metamask/design-tokens/dist/js/themes/types';

Why not bring Colors type back from the theme utils, and export it from Theme['colors']?
If the export is moved in the @metamask/design-tokens dependency (let's say a file restructure occurred), a lot of instances have to be updated.
Exporting from utils is better abstraction with only one type to keep updated if the dependency changes.

[jpcloureiro]

Suggest on importing { Theme } from '../../../../util/theme/models' and use the indexed access type Theme['colors']

This way we keep the @metamask/design-tokens imports only on utils/theme

@wachunei beat me to it 😄

[wachunei]

LGTM