Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change quotes error to individual events #4604

Merged
merged 5 commits into from
Jul 12, 2022
Merged

Change quotes error to individual events #4604

merged 5 commits into from
Jul 12, 2022

Conversation

wachunei
Copy link
Member

@wachunei wachunei commented Jun 28, 2022 •
edited

This PR sends individual events per provider that return a quote with error.

@wachunei wachunei requested a review from a team as a code owner June 28, 2022 18:36
@wachunei wachunei added the release-5.4.0 PRs for v5.4.0 release label Jun 28, 2022
gantunesr
gantunesr reviewed Jul 6, 2022
View reviewed changes
Copy link
Member

@gantunesr gantunesr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll wait for the other comments to be resolved before approving

app/components/UI/FiatOnRampAggregator/Views/GetQuotes.tsx Show resolved Hide resolved
@gantunesr gantunesr added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jul 6, 2022
alaahd
alaahd approved these changes Jul 7, 2022
View reviewed changes
Copy link
Contributor

@alaahd alaahd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! You just need to rebase with main.

gantunesr
gantunesr approved these changes Jul 7, 2022
View reviewed changes
Copy link
Member

@gantunesr gantunesr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gantunesr gantunesr added needs-qa Any New Features that needs a full manual QA prior to being added to a release. and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Jul 7, 2022
@cortisiko cortisiko added QA Passed A successful QA run through has been done and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Jul 12, 2022
@cortisiko
Copy link
Member

Spoke with Lorenzo and he confirmed this was QA passed. See discussion here https://consensys.slack.com/archives/C039U5608K0/p1657634239853159?thread_ts=1657131054.888789&cid=C039U5608K0

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@cortisiko cortisiko merged commit d6e7fb5 into main Jul 12, 2022
@cortisiko cortisiko deleted the feature/onramp-analytics-quotes-error branch July 12, 2022 19:00
@github-actions github-actions bot locked and limited conversation to collaborators Jul 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alaahd alaahd alaahd approved these changes

@gantunesr gantunesr gantunesr approved these changes

Assignees
No one assigned
Labels
QA Passed A successful QA run through has been done release-5.4.0 PRs for v5.4.0 release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@wachunei @cortisiko @alaahd @gantunesr @VikChawla