Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component/4598 multiselect list item #4606

Merged
merged 6 commits into from
Jun 30, 2022
Merged

Conversation

Cal-L
Copy link
Contributor

@Cal-L Cal-L commented Jun 29, 2022

Description

#4598

Not selected
image

Selected
image

Multiselect
image

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@Cal-L Cal-L added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jun 29, 2022
@Cal-L Cal-L requested a review from a team as a code owner June 29, 2022 07:37
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Contributor

@jpcloureiro jpcloureiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Cal-L Cal-L merged commit b10b198 into main Jun 30, 2022
@Cal-L Cal-L deleted the component/4598-multiselect-list-item branch June 30, 2022 17:39
@github-actions github-actions bot locked and limited conversation to collaborators Jun 30, 2022
@Cal-L Cal-L added release-5.4.0 PRs for v5.4.0 release and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Jul 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-5.4.0 PRs for v5.4.0 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants