Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pull to refresh and new design to Fiat Order Details view #4609

Merged
merged 5 commits into from
Jul 11, 2022
Merged

Add pull to refresh and new design to Fiat Order Details view #4609

merged 5 commits into from
Jul 11, 2022

Conversation

wachunei
Copy link
Member

@wachunei wachunei commented Jun 29, 2022 •
edited

This PR adds a new design for the Fiat Orders Details View which includes a pull to refresh action.

Before/After

Simulator.Screen.Recording.-.iPhone.11.Pro.-.2022-07-06.at.16.08.50.mp4
Simulator.Screen.Recording.-.iPhone.11.Pro.-.2022-07-06.at.16.09.32.mp4

@wachunei wachunei added the release-5.4.0 PRs for v5.4.0 release label Jun 29, 2022
@wachunei wachunei requested a review from a team as a code owner June 29, 2022 19:43
gantunesr
gantunesr reviewed Jul 6, 2022
View reviewed changes
app/components/UI/FiatOnRampAggregator/components/Account.tsx Show resolved Hide resolved
app/components/UI/FiatOnRampAggregator/components/OrderDetails.tsx Show resolved Hide resolved
app/components/UI/FiatOnRampAggregator/components/OrderDetails.tsx Show resolved Hide resolved
app/components/UI/FiatOnRampAggregator/components/OrderDetails.tsx Show resolved Hide resolved
app/components/UI/FiatOnRampAggregator/components/OrderDetails.tsx Outdated Show resolved Hide resolved
app/components/UI/FiatOnRampAggregator/components/OrderDetails.tsx Outdated Show resolved Hide resolved
app/components/UI/FiatOnRampAggregator/components/OrderDetails.tsx Outdated Show resolved Hide resolved
app/components/UI/FiatOnRampAggregator/components/OrderDetails.tsx Show resolved Hide resolved
@gantunesr gantunesr added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jul 6, 2022
alaahd
alaahd approved these changes Jul 7, 2022
View reviewed changes
Copy link
Contributor

@alaahd alaahd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a small comment, LGTM!

gantunesr
gantunesr approved these changes Jul 7, 2022
View reviewed changes
Copy link
Member

@gantunesr gantunesr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gantunesr gantunesr added needs-qa Any New Features that needs a full manual QA prior to being added to a release. and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Jul 7, 2022
@wachunei wachunei added needs-qa Any New Features that needs a full manual QA prior to being added to a release. QA Passed A successful QA run through has been done and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Jul 8, 2022
@wachunei wachunei removed the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Jul 8, 2022
@cortisiko cortisiko merged commit 3bddbe2 into main Jul 11, 2022
@cortisiko cortisiko deleted the feature/onramp-order-details-redesign branch July 11, 2022 19:38
@github-actions github-actions bot locked and limited conversation to collaborators Jul 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alaahd alaahd alaahd approved these changes

@gantunesr gantunesr gantunesr approved these changes

Assignees
No one assigned
Labels
QA Passed A successful QA run through has been done release-5.4.0 PRs for v5.4.0 release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@wachunei @alaahd @gantunesr @cortisiko