Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Remove TouchableOpacity from DeleteMetaMetricsData component #4610

Merged
merged 2 commits into from
Jun 30, 2022
Merged

[FIX] Remove TouchableOpacity from DeleteMetaMetricsData component #4610

merged 2 commits into from
Jun 30, 2022
+7 −18

Conversation

gantunesr
Copy link
Member

Description

Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions,
1. What is the reason for the change?
2. What is the improvement/solution?

Removed the TouchableOpacity from the component since Text API also has a onPress prop.

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

NA

Issue

Progresses #NA

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@gantunesr gantunesr added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jun 30, 2022
@gantunesr gantunesr requested a review from a team as a code owner June 30, 2022 03:40
Fatxx
Fatxx approved these changes Jun 30, 2022
View reviewed changes
Copy link
Contributor

@Fatxx Fatxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gantunesr gantunesr merged commit ce5c0f4 into main Jun 30, 2022
@gantunesr gantunesr deleted the fix/remove-touchable-opacity-delete-metrics branch June 30, 2022 12:55
@github-actions github-actions bot locked and limited conversation to collaborators Jun 30, 2022
@gantunesr gantunesr added Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Jun 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Fatxx Fatxx Fatxx approved these changes

Assignees
No one assigned
Labels
Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gantunesr @Fatxx