Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component/4079 avatar group #4613

Merged
merged 13 commits into from
Jul 29, 2022
Merged

Component/4079 avatar group #4613

merged 13 commits into from
Jul 29, 2022

Conversation

jpcloureiro
Copy link
Contributor

@jpcloureiro jpcloureiro commented Jun 30, 2022

Description

#4079

Screenshots/Recordings

Component Story

Storybook knob to control the amount of stacked token avatars

Stack with 4 Token avatars

Overflow counter appears when more than 4 token avatars are stacked

@jpcloureiro jpcloureiro added the permission-system New UI components for Permission System label Jun 30, 2022
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jpcloureiro jpcloureiro force-pushed the component/4079-avatar-group branch 3 times, most recently from 06c06d6 to 5048c0e Compare July 15, 2022 12:56
@jpcloureiro jpcloureiro marked this pull request as ready for review July 19, 2022 17:08
@jpcloureiro jpcloureiro requested a review from a team as a code owner July 19, 2022 17:08
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments and suggestions

Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple more comments :)

Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After changes are resolved, LGTM!

@jpcloureiro jpcloureiro merged commit 04f03b9 into main Jul 29, 2022
@jpcloureiro jpcloureiro deleted the component/4079-avatar-group branch July 29, 2022 16:28
@github-actions github-actions bot locked and limited conversation to collaborators Jul 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
permission-system New UI components for Permission System
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants