-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Component/4079 avatar group #4613
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
494951b
to
caa860e
Compare
06c06d6
to
5048c0e
Compare
5dde312
to
d712252
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments and suggestions
app/component-library/components/StackedAvatars/StackedAvatars.types.ts
Outdated
Show resolved
Hide resolved
app/component-library/components/StackedAvatars/StackedAvatars.types.ts
Outdated
Show resolved
Hide resolved
app/component-library/components/StackedAvatars/StackedAvatars.types.ts
Outdated
Show resolved
Hide resolved
app/component-library/components/StackedAvatars/StackedAvatars.stories.tsx
Show resolved
Hide resolved
app/component-library/components/StackedAvatars/StackedAvatars.styles.ts
Outdated
Show resolved
Hide resolved
app/component-library/components/StackedAvatars/StackedAvatars.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple more comments :)
app/component-library/components/StackedAvatars/StackedAvatars.styles.ts
Show resolved
Hide resolved
app/component-library/components/StackedAvatars/StackedAvatars.styles.ts
Outdated
Show resolved
Hide resolved
app/component-library/components/StackedAvatars/StackedAvatars.styles.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After changes are resolved, LGTM!
e27a66b
to
f622866
Compare
Description
#4079
Screenshots/Recordings
Component Story
Storybook knob to control the amount of stacked token avatars
Stack with 4 Token avatars
Overflow counter appears when more than 4 token avatars are stacked