Handle SecureKeychain failed access while passcode enabled #4625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fatxx
added
the
needs-dev-review
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Fatxx
added
Mobile QA board
needs-qa
mobularay
added
Sev2-normal
cortisiko
added
QA in Progress
cortisiko
reviewed
Jul 26, 2022
There was a problem hiding this comment.
I am done testing but I have a question, should the remember me toggle be disabled when I:
enable passcode login > kill the app> relaunch it > instead of logging in via the passcode > tap on the cancel button?
If I were to repeat the above with faceID/fingerprint biometrics, the remember me (it actually says unlock with faceID/fingerprint) toggle is enabled.
This happens on both ios and android. Here is a recording on ios
I get [Error: User canceled the operation.] I know it is a harmless error but can we fix so it doesn’t pollute sentry?
cortisiko
added
QA'd but questions
cortisiko
added
QA Passed
cortisiko
approved these changes
Jul 27, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed an issue that leads the application to an unusable state if the user cancels the passcode authentication, and implements error handling when we try to access SecureKeychain.
Screenshots/Recordings
RPReplay_Final1657010928.mov
Issue
Progresses #260
Checklist