Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typing support for payment methods to be used instead of payment IDs #4627

Merged
merged 18 commits into from
Jul 27, 2022

Conversation

alaahd
Copy link
Contributor

@alaahd alaahd commented Jul 6, 2022

Description

Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions,
1. What is the reason for the change?
2. What is the improvement/solution?

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@alaahd alaahd requested a review from a team as a code owner July 6, 2022 13:01
@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2022

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@wachunei wachunei marked this pull request as draft July 6, 2022 14:23
@alaahd alaahd changed the title WIP: Add typing support for payment methods to be used instead of payment IDs Add typing support for payment methods to be used instead of payment IDs Jul 7, 2022
@alaahd alaahd marked this pull request as ready for review July 7, 2022 12:15
app/components/UI/FiatOnRampAggregator/sdk/index.tsx Outdated Show resolved Hide resolved
@wachunei wachunei added the release-5.5.0 PRs for v5.5.0 release label Jul 20, 2022
@wachunei wachunei added the team-ramp issues related to Ramp features label Jul 21, 2022
@wachunei wachunei self-requested a review July 21, 2022 17:04
@wachunei wachunei dismissed their stale review July 21, 2022 17:04

Requested changes were addressed by reviewer

@mobularay mobularay added regression-RC DEPRECATED: Please use "regresssion-RC-x.y.z" label instead and removed regression-RC DEPRECATED: Please use "regresssion-RC-x.y.z" label instead labels Jul 26, 2022
@mobularay
Copy link
Contributor

mobularay commented Jul 26, 2022

@wachunei @alaahd has a Mobile dev review this ticket? Has feature QA been completed?

@wachunei
Copy link
Member

@mobularay

has a Mobile dev review this ticket?

Nope

Has QA feature been completed?

No, we need to upgrade SDK to a new version and deploy the API to QA it, those tasks are in progress right now

@wachunei wachunei added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jul 26, 2022
@wachunei wachunei added the Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking label Jul 26, 2022
Copy link
Member

@gantunesr gantunesr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tu like

@wachunei wachunei removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jul 27, 2022
@wachunei wachunei merged commit 300f47e into MetaMask:main Jul 27, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jul 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-5.5.0 PRs for v5.5.0 release Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-ramp issues related to Ramp features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants