-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use default QR code colors #4639
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@Cal-L can you improve the description of the PR? For example, including screenshots of the before and after for an easier understanding of the changes for external teams like CS. |
…to fix/4490-fix-qr-code
I am still experiencing the inability to scan a QR from my Android device when in dark mode, from the I believe that we need a white border around the QR to resolve this. |
@plasmacorral Just updated all QR codes with white padding around it. |
Description
#4490
Remove setting colors of QR codes - Use default QR codes, which is black and white. QR code colors remain the same between light and dark mode. This was updated in 4 places - PaymentRequestSuccess, ReceiveRequest, AddressQRCode, and RevealPrivateCredential flows.
Here's an example of a QR code in light mode before and after the fix.
BEFORE:
AFTER:
And dark mode
BEFORE:
AFTER:
Screenshots/Recordings
If applicable, add screenshots and/or recordings to visualize the before and after of your change
Issue
Progresses #???
Checklist