Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use default QR code colors #4639

Merged
merged 7 commits into from
Jul 29, 2022
Merged

Use default QR code colors #4639

merged 7 commits into from
Jul 29, 2022

Conversation

Cal-L
Copy link
Contributor

@Cal-L Cal-L commented Jul 7, 2022

Description

#4490
Remove setting colors of QR codes - Use default QR codes, which is black and white. QR code colors remain the same between light and dark mode. This was updated in 4 places - PaymentRequestSuccess, ReceiveRequest, AddressQRCode, and RevealPrivateCredential flows.

Here's an example of a QR code in light mode before and after the fix.
BEFORE:
image
AFTER:
image

And dark mode
BEFORE:
image

AFTER:
image

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@Cal-L Cal-L requested a review from a team as a code owner July 7, 2022 21:52
@Cal-L Cal-L added the release-5.4.0 PRs for v5.4.0 release label Jul 7, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2022

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Cal-L Cal-L added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jul 7, 2022
Copy link
Member

@gantunesr gantunesr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@gantunesr
Copy link
Member

@Cal-L can you improve the description of the PR? For example, including screenshots of the before and after for an easier understanding of the changes for external teams like CS.

@gantunesr gantunesr added needs-qa Any New Features that needs a full manual QA prior to being added to a release. Mobile QA board and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Jul 8, 2022
@chrisleewilcox chrisleewilcox added QA in Progress QA has started on the feature. and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Jul 12, 2022
@Cal-L Cal-L added release-5.5.0 PRs for v5.5.0 release and removed release-5.4.0 PRs for v5.4.0 release labels Jul 12, 2022
@cortisiko cortisiko added release-5.6.0 PRs for v5.6.0 release and removed release-5.5.0 PRs for v5.5.0 release labels Jul 27, 2022
@plasmacorral plasmacorral added QA'd - Issues Found QA has been complete, however issues have been discovered that need to be addressed and removed QA in Progress QA has started on the feature. labels Jul 27, 2022
@plasmacorral
Copy link
Contributor

I am still experiencing the inability to scan a QR from my Android device when in dark mode, from the QR journal from the mac app store as reported in the initial issue.

I believe that we need a white border around the QR to resolve this.

@Cal-L
Copy link
Contributor Author

Cal-L commented Jul 27, 2022

@plasmacorral Just updated all QR codes with white padding around it.
Here's an example of one in dark mode
image

And the same one in light mode
image

@plasmacorral plasmacorral added QA in Progress QA has started on the feature. and removed QA'd - Issues Found QA has been complete, however issues have been discovered that need to be addressed labels Jul 29, 2022
@plasmacorral plasmacorral removed the QA in Progress QA has started on the feature. label Jul 29, 2022
@plasmacorral plasmacorral added the QA Passed A successful QA run through has been done label Jul 29, 2022
@plasmacorral plasmacorral merged commit a0549ac into main Jul 29, 2022
@plasmacorral plasmacorral deleted the fix/4490-fix-qr-code branch July 29, 2022 20:14
@github-actions github-actions bot locked and limited conversation to collaborators Jul 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
QA Passed A successful QA run through has been done release-5.6.0 PRs for v5.6.0 release team-accounts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants