Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create confirmation modal component #4640

Merged
merged 10 commits into from
Aug 5, 2022
Merged

Conversation

Cal-L
Copy link
Contributor

@Cal-L Cal-L commented Jul 7, 2022

Description

#4717
This component is already hooked up to React Navigation as a modal.

Normal variant (Blue CTA)
image

Danger variant (Red CTA)
image

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2022

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Cal-L Cal-L marked this pull request as ready for review July 8, 2022 21:42
@Cal-L Cal-L requested a review from a team as a code owner July 8, 2022 21:42
@Cal-L Cal-L added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) release-5.5.0 PRs for v5.5.0 release labels Jul 8, 2022
@sethkfman sethkfman added release-5.6.0 PRs for v5.6.0 release and removed release-5.5.0 PRs for v5.5.0 release labels Jul 26, 2022
Copy link
Member

@gantunesr gantunesr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I only left non-blocking small comments

locales/languages/en.json Outdated Show resolved Hide resolved
@Cal-L Cal-L merged commit 2d053ac into main Aug 5, 2022
@Cal-L Cal-L deleted the component/confirmation-modal branch August 5, 2022 20:26
@github-actions github-actions bot locked and limited conversation to collaborators Aug 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) release-5.6.0 PRs for v5.6.0 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants