Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add On-Ramp Aggregator a11y improvements #4643

Merged
merged 4 commits into from
Jul 26, 2022
Merged

Add On-Ramp Aggregator a11y improvements #4643

merged 4 commits into from
Jul 26, 2022

Conversation

wachunei
Copy link
Member

@wachunei wachunei commented Jul 8, 2022

Description

This PR improves the interaction of On-Ramp components through screen readers

1. What is the reason for the change?
Users reported the inability to properly interact with our UI using screen readers

2. What is the improvement/solution?
The solution is to better define the components that should act as group or not. When acting as group, children elements are not reachable.

Issue

https://consensys.slack.com/archives/G8RSKCNCD/p1655139704143279

@wachunei wachunei marked this pull request as ready for review July 8, 2022 18:36
@wachunei wachunei requested a review from a team as a code owner July 8, 2022 18:36
@wachunei wachunei added needs-qa Any New Features that needs a full manual QA prior to being added to a release. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) release-5.4.0 PRs for v5.4.0 release labels Jul 8, 2022
@wachunei wachunei changed the title Add On-Ramp Aggregator a11y improvemnts Add On-Ramp Aggregator a11y improvements Jul 8, 2022
rickycodes
rickycodes approved these changes Jul 8, 2022
View reviewed changes
Copy link
Member

@rickycodes rickycodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks straight forward enough to me 👍

@wachunei wachunei removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jul 8, 2022
@sethkfman sethkfman added release-5.5.0 PRs for v5.5.0 release and removed release-5.4.0 PRs for v5.4.0 release labels Jul 12, 2022
@wachunei wachunei added the team-ramp issues related to Ramp features label Jul 21, 2022
@mobularay
Copy link
Contributor

@wachunei Has QA feature been completed?

@wachunei
Copy link
Member Author

Yes but this will also need a spot check in-device with the screen readers. I'll remove needs-qa and add spot check. I will also merge this.

@wachunei wachunei added Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Jul 26, 2022
@wachunei wachunei merged commit 2f59561 into main Jul 26, 2022
@wachunei wachunei deleted the fix/onramp-accessible-box branch July 26, 2022 15:42
@github-actions github-actions bot locked and limited conversation to collaborators Jul 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rickycodes rickycodes rickycodes approved these changes

Assignees
No one assigned
Labels
release-5.5.0 PRs for v5.5.0 release Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-ramp issues related to Ramp features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@wachunei @mobularay @rickycodes @sethkfman