Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update url formats popular networks #4644

Merged
merged 3 commits into from
Jul 11, 2022
Merged

Update url formats popular networks #4644

merged 3 commits into from
Jul 11, 2022

Conversation

blackdevelopa
Copy link
Contributor

@blackdevelopa blackdevelopa commented Jul 8, 2022 •
edited

Description

Update url formats in popular network.

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Progresses #314

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@blackdevelopa blackdevelopa requested a review from a team as a code owner July 8, 2022 19:52
@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2022

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sethkfman sethkfman changed the title hide key when adding popular network Update url formats popular networks Jul 8, 2022
@blackdevelopa blackdevelopa self-assigned this Jul 11, 2022
@blackdevelopa blackdevelopa added needs-qa Any New Features that needs a full manual QA prior to being added to a release. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Jul 11, 2022
sethkfman
sethkfman approved these changes Jul 11, 2022
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cortisiko cortisiko added QA Passed A successful QA run through has been done and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Jul 11, 2022
cortisiko
cortisiko approved these changes Jul 11, 2022
View reviewed changes
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is 🌮 🌮 🌮

@cortisiko cortisiko added the release-5.4.0 PRs for v5.4.0 release label Jul 11, 2022
@cortisiko cortisiko merged commit 87d7635 into main Jul 11, 2022
@cortisiko cortisiko deleted the improvement/314 branch July 11, 2022 18:43
@github-actions github-actions bot locked and limited conversation to collaborators Jul 11, 2022
@blackdevelopa blackdevelopa added the team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead label Jul 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sethkfman sethkfman sethkfman approved these changes

@cortisiko cortisiko cortisiko approved these changes

Assignees

@blackdevelopa blackdevelopa

Labels
QA Passed A successful QA run through has been done release-5.4.0 PRs for v5.4.0 release team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@blackdevelopa @sethkfman @cortisiko