Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Plain texts in code #4656

Merged
merged 1 commit into from
Jul 12, 2022
Merged

[FIX] Plain texts in code #4656

merged 1 commit into from
Jul 12, 2022

Conversation

gantunesr
Copy link
Member

Description

Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions,
1. What is the reason for the change?
2. What is the improvement/solution?

Move the following string to the en.json file,

  • Security Alert
  • In order to proceed, you need to turn Passcode on or any biometrics authentication method supported in your device (FaceID, TouchID or Fingerprint)

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@gantunesr gantunesr requested a review from a team as a code owner July 12, 2022 12:55
@gantunesr gantunesr added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking stability-team labels Jul 12, 2022
@tommasini
Copy link
Contributor

LGTM!

Fatxx
Fatxx approved these changes Jul 12, 2022
View reviewed changes
Copy link
Contributor

@Fatxx Fatxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gantunesr gantunesr merged commit ae3d8e7 into main Jul 12, 2022
@gantunesr gantunesr deleted the fix/mv-text-to-enjs branch July 12, 2022 13:13
@gantunesr gantunesr added release-5.4.0 PRs for v5.4.0 release and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Jul 12, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jul 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Fatxx Fatxx Fatxx approved these changes

Assignees
No one assigned
Labels
release-5.4.0 PRs for v5.4.0 release Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gantunesr @tommasini @Fatxx