Account nickname is always defined #4684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
Looks great to me! |
tommasini
added
the
needs-dev-review
gantunesr
reviewed
Jul 21, 2022
tommasini
changed the title
gantunesr
approved these changes
Aug 11, 2022
tommasini
added
needs-qa
cortisiko
added
QA in Progress
cortisiko
requested changes
Aug 11, 2022
There was a problem hiding this comment.
@tommasini I found a fun edge case:
If I were to:
- long press to edit my account nickname
- remove the current name
- tap on the space bar to set ' ' as my account nickname
- upon doing so, I still experience the bug where I am unable to edit my account nickname after setting it to ' '
see recording
cortisiko
added
QA'd - Issues Found
|
@cortisiko Really well catched, I was not considering the blank spaces!! Thank you Curtis! Awesome!!! @gantunesr Could you give me another review please? |
tommasini
added
the
needs-dev-review
gantunesr
approved these changes
Aug 12, 2022
tommasini
added
needs-qa
cortisiko
removed
the
needs-qa
cortisiko
added
QA Passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The issue is that when the nickname of the account would be empty, it would be non editable.
Proposed Solution
The proposed solution it is, when the name it's empty we will assume that the name of the account will be the last name of it.
Example:
If it was "Account 2" after confirm the empty string on the account name, it will come back to be "Account 2"
Also its proposed, for the users that already have no nickname on their accounts we set the default name "Account" when the user opens the app.
Code Impact
Low
Test Cases
Case1:
Screenshots/Recordings
WhatsApp.Video.2022-07-18.at.6.54.45.PM.mp4
If applicable, add screenshots and/or recordings to visualize the before and after of your change
Issue
Progresses #4308
Checklist