Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix allowsInlineMediaPlayback prop name #4685

Merged
merged 5 commits into from
Jul 26, 2022
Merged

Fix allowsInlineMediaPlayback prop name #4685

merged 5 commits into from
Jul 26, 2022

Conversation

wachunei
Copy link
Member

Description

This PR fixes a typo in a WebView component prop.

Screenshots/Recordings
NA

Issue

NA

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@wachunei wachunei added the release-5.5.0 PRs for v5.5.0 release label Jul 20, 2022
@wachunei wachunei marked this pull request as ready for review July 20, 2022 19:57
@wachunei wachunei requested a review from a team as a code owner July 20, 2022 19:57
gantunesr
gantunesr approved these changes Jul 21, 2022
View reviewed changes
Copy link
Member

@gantunesr gantunesr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gantunesr gantunesr added the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Jul 21, 2022
@wachunei wachunei added the team-ramp issues related to Ramp features label Jul 21, 2022
@mobularay
Copy link
Contributor

@wachunei Has feature QA been completed?

@wachunei wachunei added Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Jul 26, 2022
@lorenzosantos
Copy link

lorenzosantos commented Jul 26, 2022 •
edited

@mobularay This is a bug patch that doesn't require full manual QA. Instead, a spot check with the RC build will be sufficient.

@wachunei wachunei merged commit 43c3a6f into main Jul 26, 2022
@wachunei wachunei deleted the fix/onramp-webview-playback-prop-name branch July 26, 2022 16:35
@github-actions github-actions bot locked and limited conversation to collaborators Jul 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gantunesr gantunesr gantunesr approved these changes

Assignees
No one assigned
Labels
release-5.5.0 PRs for v5.5.0 release Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-ramp issues related to Ramp features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@wachunei @mobularay @lorenzosantos @gantunesr