Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add wordd 'buy' to limit description #4704

Merged
merged 2 commits into from
Jul 21, 2022
Merged

Add wordd 'buy' to limit description #4704

merged 2 commits into from
Jul 21, 2022
+3 −3

Conversation

wachunei
Copy link
Member

Description

This PR adds the word 'buy' to Payment Methods

Screenshots/Recordings
Before/After
Screen Shot 2022-07-20 at 14 54 57Screen Shot 2022-07-20 at 14 54 28

Issue

Solves https://consensyssoftware.atlassian.net/browse/ONRAMP-88

@wachunei wachunei requested a review from a team as a code owner July 20, 2022 19:56
@wachunei wachunei added the release-5.5.0 PRs for v5.5.0 release label Jul 20, 2022
gantunesr
gantunesr approved these changes Jul 21, 2022
View reviewed changes
Copy link
Member

@gantunesr gantunesr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gantunesr
Copy link
Member

I think this can be QA reviewed during regression. I'll add the spot check label

cc @cortisiko @wachunei

@gantunesr gantunesr added the Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking label Jul 21, 2022
@wachunei wachunei added the team-ramp issues related to Ramp features label Jul 21, 2022
@wachunei wachunei merged commit 9657cab into main Jul 21, 2022
@wachunei wachunei deleted the fix/onramp-buy-limit-wording branch July 21, 2022 17:12
@github-actions github-actions bot locked and limited conversation to collaborators Jul 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gantunesr gantunesr gantunesr approved these changes

Assignees
No one assigned
Labels
release-5.5.0 PRs for v5.5.0 release Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-ramp issues related to Ramp features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wachunei @gantunesr