Component/4226 bottom sheet #4718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to component/4226-bottom-sheet
…to component/4226-bottom-sheet
…to component/4226-bottom-sheet
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Cal-L
added
needs-dev-review
sethkfman
added
release-5.6.0
…to component/4226-bottom-sheet
brianacnguyen
requested changes
Aug 1, 2022
app/component-library/components/BottomSheet/BottomSheet.constants.ts
Outdated
Show resolved
Hide resolved
app/component-library/components/BottomSheet/BottomSheet.stories.tsx
Outdated
Show resolved
Hide resolved
app/component-library/components/BottomSheet/BottomSheet.types.ts
Outdated
Show resolved
Hide resolved
brianacnguyen
approved these changes
Aug 5, 2022
* Create sheet header component * Finish SheetHeader component * Clean up sheet header
owencraston
approved these changes
Aug 5, 2022
cortisiko
removed
the
needs-dev-review
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#4226
Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions,
1. What is the reason for the change?
2. What is the improvement/solution?
Screenshots/Recordings
If applicable, add screenshots and/or recordings to visualize the before and after of your change
Issue
Progresses #???
Checklist