Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix duplicate property in on-ramp events definition #4740

Merged
merged 2 commits into from
Aug 5, 2022
Merged

Fix duplicate property in on-ramp events definition #4740

merged 2 commits into from
Aug 5, 2022

Conversation

wachunei
Copy link
Member

Description

This PR fixes a duplicate property definition error

@wachunei wachunei requested a review from a team as a code owner July 27, 2022 22:18
@wachunei wachunei added team-ramp issues related to Ramp features release-5.6.0 PRs for v5.6.0 release needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Jul 27, 2022
Cal-L
Cal-L approved these changes Aug 1, 2022
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wachunei wachunei added Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Aug 3, 2022
@cortisiko cortisiko merged commit 8e557da into main Aug 5, 2022
@cortisiko cortisiko deleted the fix/onramp-events branch August 5, 2022 19:21
@github-actions github-actions bot locked and limited conversation to collaborators Aug 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Cal-L Cal-L Cal-L approved these changes

Assignees
No one assigned
Labels
release-5.6.0 PRs for v5.6.0 release Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-ramp issues related to Ramp features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wachunei @Cal-L @cortisiko