Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Payment Method logos #4743

Merged
merged 3 commits into from
Aug 9, 2022
Merged

Conversation

wachunei
Copy link
Member

Description

This PR removes hardcoded images from the codebase and renders the images coming from the server.

@wachunei wachunei added needs-qa Any New Features that needs a full manual QA prior to being added to a release. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-ramp issues related to Ramp features release-5.6.0 PRs for v5.6.0 release labels Jul 27, 2022
@wachunei wachunei requested a review from a team as a code owner July 27, 2022 23:43
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments - after changes LGTM!

@alaahd
Copy link
Contributor

alaahd commented Aug 3, 2022

LGTM!

@wachunei wachunei removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Aug 3, 2022
@wachunei wachunei merged commit 76afac6 into main Aug 9, 2022
@wachunei wachunei deleted the feature/onramp-payment-method-logos branch August 9, 2022 13:28
@github-actions github-actions bot locked and limited conversation to collaborators Aug 9, 2022
@wachunei wachunei removed the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Aug 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-5.6.0 PRs for v5.6.0 release team-ramp issues related to Ramp features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants