Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PS] Componentize Cell #4083 #4756

Merged
merged 5 commits into from
Aug 3, 2022
Merged

[PS] Componentize Cell #4083 #4756

merged 5 commits into from
Aug 3, 2022

Conversation

brianacnguyen
Copy link
Contributor

@brianacnguyen brianacnguyen commented Jul 29, 2022 •
edited

Description

#4083

Screenshots/Recordings

Cell Container Select Item
Screen Shot 2022-08-01 at 9 48 10 PM
Cell Container MultiSelect Item
Screen Shot 2022-08-01 at 9 47 55 PM

Cell
Screen Shot 2022-08-01 at 9 47 03 PM
Screen Shot 2022-08-01 at 9 47 25 PM

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@brianacnguyen brianacnguyen requested a review from a team as a code owner July 29, 2022 18:16
@brianacnguyen brianacnguyen added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) release-5.6.0 PRs for v5.6.0 release labels Jul 29, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 29, 2022 •
edited

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@brianacnguyen
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

Cal-L
Cal-L approved these changes Jul 29, 2022
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments!

app/constants/test-ids.js Outdated Show resolved Hide resolved
storybook/storyLoader.js Outdated Show resolved Hide resolved
app/component-library/components/CellContainerSelectOption/CellContainerSelectOption.tsx Outdated Show resolved Hide resolved
app/component-library/components/CellContainerSelectOption/CellContainerSelectOption.types.ts Outdated Show resolved Hide resolved
...ent-library/components/CellContainerSelectOption/CellContainerSelectOption.snapshot.test.tsx Outdated Show resolved Hide resolved
app/component-library/components/Cell/Cell.styles.ts Outdated Show resolved Hide resolved
app/component-library/components/Cell/Cell.stories.tsx Outdated Show resolved Hide resolved
app/component-library/components/Cell/Cell.stories.tsx Outdated Show resolved Hide resolved
app/component-library/components/Cell/Cell.constants.ts Outdated Show resolved Hide resolved
app/component-library/components/Cell/Cell.snapshot.test.tsx Outdated Show resolved Hide resolved
brianacnguyen
brianacnguyen commented Aug 2, 2022
View reviewed changes
Copy link
Contributor Author

@brianacnguyen brianacnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved comments

@brianacnguyen brianacnguyen merged commit 5c7df8c into main Aug 3, 2022
@brianacnguyen brianacnguyen deleted the component/4083-cell-account branch August 3, 2022 15:57
@github-actions github-actions bot locked and limited conversation to collaborators Aug 3, 2022
@brianacnguyen brianacnguyen removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Aug 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Cal-L Cal-L Cal-L approved these changes

Assignees
No one assigned
Labels
release-5.6.0 PRs for v5.6.0 release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@brianacnguyen @Cal-L