Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dapp connect Warning #4793

Merged
merged 4 commits into from
Aug 5, 2022
Merged

Dapp connect Warning #4793

merged 4 commits into from
Aug 5, 2022

Conversation

andrepimenta
Copy link
Member

Description

Warn the user to update the app to a new version

Screenshots/Recordings
Simulator Screen Shot - iPhone 11 Pro - 2022-08-03 at 15 45 16

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@andrepimenta andrepimenta added the release-5.6.0 PRs for v5.6.0 release label Aug 3, 2022
@andrepimenta andrepimenta requested a review from a team as a code owner August 3, 2022 14:49
@andrepimenta andrepimenta added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) regression-RC DEPRECATED: Please use "regresssion-RC-x.y.z" label instead needs-qa Any New Features that needs a full manual QA prior to being added to a release. and removed regression-RC DEPRECATED: Please use "regresssion-RC-x.y.z" label instead labels Aug 3, 2022
@mobularay mobularay added the team-sdk SDK team label Aug 3, 2022
owencraston
owencraston approved these changes Aug 3, 2022
View reviewed changes
Copy link
Contributor

@owencraston owencraston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful!

@cortisiko cortisiko added QA'd - Issues Found QA has been complete, however issues have been discovered that need to be addressed and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Aug 3, 2022
@cortisiko
Copy link
Member

@andrepimenta
Lone issue: on android when I attempt to deep link, I am taken to the browser

@cortisiko cortisiko merged commit 128910b into main Aug 5, 2022
@cortisiko cortisiko deleted the feature/dapps-connect-warning branch August 5, 2022 17:54
@cortisiko cortisiko added QA Passed A successful QA run through has been done and removed QA'd - Issues Found QA has been complete, however issues have been discovered that need to be addressed labels Aug 5, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Aug 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@owencraston owencraston owencraston approved these changes

Assignees
No one assigned
Labels
QA Passed A successful QA run through has been done release-5.6.0 PRs for v5.6.0 release team-sdk SDK team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@andrepimenta @cortisiko @owencraston @mobularay